Looks good: “Sometimes writing for money—rather than for art or pleasure—is really quite enjoyable.”
Unreadable: “Sometimes writing for money-rather than for art or pleasure-is really quite enjoyable.”
Yes, punctation does matter. (In French the em-dash is almost inexistant; we use parenthesis instead usually.)